Skip to content

Commit

Permalink
Fix PipSession import for pip version 20
Browse files Browse the repository at this point in the history
  • Loading branch information
rgerkin committed Jan 28, 2020
1 parent 4ac6465 commit 1aee48d
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@
try:
from pip.req import parse_requirements
from pip.download import PipSession
except:
except ImportError:
from pip._internal.req import parse_requirements
from pip._internal.download import PipSession
try:
from pip._internal.download import PipSession
except ImportError:
from pip._internal.network.session import PipSession

from setuptools import setup, find_packages

Expand Down

4 comments on commit 1aee48d

@appukuttan-shailesh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgerkin : I seem to be getting an error on ReadTheDocs with the old code:
https://readthedocs.org/projects/demounit/builds/10419740/

Can you make a new minor release with this fix?

@rgerkin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appukuttan-shailesh Do you want it on PyPI or as a GitHub release?

@rgerkin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appukuttan-shailesh Nevermind, I've added both (new version 0.2.2 containing this commit).

@appukuttan-shailesh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was intending a PyPI release. Thanks for the quick response.

Please sign in to comment.