Passing parameters to parents of RunnableModel #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any additional parameters to the Model class are set as `params`. However, this is not the case for its child class RunnableModel, and therefore can't be used for child classes derived from it. To handle parameter input consistently they should be passed all the way up to the Model class. So, this PR adds `**params` to the RunnableModel init and to its super call.
|
@rgutzen Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any additional parameters to the Model class are set as
params. However, this is not the case for its child class RunnableModel, and therefore can't be used for child classes derived from it. To handle parameter input consistently they should be passed all the way up to the Model class. So, this PR adds**paramsto the RunnableModel init and to its super call.