Allow dependency names that start with a number (+ parsing regex cleanup) #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to declare and build packages where the package name starts with a digit but it wasn't possible to declare them as dependencies of another package. This fixes science-computing#356 and I'm also adding a test for it to avoid regressions. Now we could package `0ad`, `389-ds`, `6tunnel`, `7z`, `9pfs`, etc. \o/ Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
Let's avoid copy-pasted code :) Using assertion macros in helper functions isn't ideal but the error messages should contain enough context to figure out what went wrong. Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
To avoid potentially unintended regressions when changing the regex. Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
The parentheses aren't required here. They can still help with readability but in this case it might be better without them (the square brackets should be sufficient for a quick orientation) so I'll drop them. Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
"Any named character class may appear inside a bracketed [...] character
class. For example, [\p{Greek}[:digit:]]" [0]
[0]: https://docs.rs/regex/1.10.3/regex/index.html#character-classes
Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
The escaping shouldn't be required for "." and "*" inside a bracketed character class (`[...]`) and we can avoid it for "-" if we place it at the beginning or the end of the bracketed character class. The escaping was also a bit confusing as "\" had to be escaped with another backslash as it's a Rust string (raw strings would be better in this case). Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
The last three `dep_parse_expect_err()` examples match the regex but aren't supported by the version parsing yet (`a *` would also match the regex with an `[:alnum:]` at the end). Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
primeos-work
force-pushed
the
dependency-parsing-regex-fix-and-cleanup
branch
from
03f950f
to
b11c677
Compare
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports dependencies where the package name starts with a digit and tries to simplify the regex a bit by dropping unnecessary syntax.