Update clap #41
Merged
Update clap #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Between clap 3.0 and clap 4.0, the way how values are fetched from the CLI has changed. Notably the Arg::value_of and Arg::values_of functions were replaced by something that can actually be a bit more typed. This patch rewrites all these uses and introduces a bit more typing in the CLI definition itself. Types like integers or uuid::Uuid are moved to the CLI definition, because these are trivial to make into clap ValueParser types. More types should and will be transformed to be able to catch errors already in CLI parsing instead of down the road during the execution of butido. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
update-clap
branch
2 times, most recently
from
b0ae2eb
to
c1cdd3f
Compare
This rewrites the environment value parsing code using the previous implementation of the CLI validator function, that had a more sophisticated parsing implementation. The CLI validator function gets then transformed to a value parser, using that parsing code again. Less code, less bugs. Yay! Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
update-clap
branch
from
c1cdd3f
to
d69257d
Compare
|
Great! I tested with a few submits and arguments and it works great! |
|
I'd say if your basic stuff works, go ahead and merge this! |
|
move fast and break things? ;) |
As long as CI is green, nothing is broken, right? 😉 |
|
yeah, true :) |
|
Build succeeded: |
|
Of course right after merging i got this: $ butido build tree -I local:rh8-default -L 1.8.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
clapdependency to clap 4.0.This is a bit more involved, as clap changed quite a bit between major versions. Also, this introduces more typing to the CLI parsing, which should result in less validation/parsing code down the road, which is really nice.
There are some improvements I plan to make for the CLI parsing code that are not yet included here, but I guess as a first step this is more than enough. Feel free to review extensively. I think testing this would also be nice, especially since I cannot and as the parsing behaviour of clap might have changed in subtle ways that are not covered by any integration tests in this repository (would be really nice to have some...)