Skip to content

Commit

Permalink
update to new versions of attr_json and faster_s3_urls
Browse files Browse the repository at this point in the history
New versions have optimizations to make fewer string allocations. Found in investigating #2449, in the end I am not thinking this is actually relevant, but still doesn't hurt to tidy up.
  • Loading branch information
jrochkind committed Dec 4, 2023
1 parent ca8a86e commit a2fed98
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ gem 'font-awesome-rails', '~> 4.7'
gem "lograge", "< 2"
gem "device_detector", "~> 1.0" # user-agent parsing we use for logging

gem "attr_json", "~> 2.0"
gem "attr_json", "~> 2.3"

gem 'kithe', "~> 2.13"

Expand All @@ -130,7 +130,7 @@ gem "shrine", "~> 3.3" #, path: "../shrine"
gem "uppy-s3_multipart"
gem "content_disposition", "~> 1.0"

gem 'faster_s3_url', "< 2" # for generating s3 urls faster!
gem 'faster_s3_url', "~> 1.1" # for generating s3 urls faster!

gem "ransack", "~> 4.0" # used as an aid for ADMIM dashboard search/sorting -- we'd like to move away from it
gem "kaminari", "~> 1.2"
Expand Down
8 changes: 4 additions & 4 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ GEM
alba (2.4.2)
ansi (1.5.0)
ast (2.4.2)
attr_json (2.2.0)
attr_json (2.3.0)
activerecord (>= 6.0.0, < 7.2)
autoprefixer-rails (10.4.15.0)
execjs (~> 2)
Expand Down Expand Up @@ -258,7 +258,7 @@ GEM
faraday-net_http (3.0.2)
faraday-retry (2.2.0)
faraday (~> 2.0)
faster_s3_url (1.0.0)
faster_s3_url (1.1.0)
fastimage (2.2.7)
ffi (1.16.3)
ffi-compiler (1.0.1)
Expand Down Expand Up @@ -729,7 +729,7 @@ DEPENDENCIES
active_encode (~> 1.0, >= 1.2.1)
activerecord-postgres_enum (~> 2.0)
alba (~> 2.0)
attr_json (~> 2.0)
attr_json (~> 2.3)
aws-sdk-cloudwatchevents (~> 1.0)
aws-sdk-cloudwatchlogs (~> 1.0)
aws-sdk-mediaconvert (~> 1.0)
Expand All @@ -755,7 +755,7 @@ DEPENDENCIES
factory_bot_rails
faraday (~> 2.0)
faraday-retry (~> 2.0)
faster_s3_url (< 2)
faster_s3_url (~> 1.1)
font-awesome-rails (~> 4.7)
hirefire-resource (>= 0.10.1)
honeybadger (~> 5.0)
Expand Down

0 comments on commit a2fed98

Please sign in to comment.