Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use build-and-inspect-packages, fix typo in guide #322

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: use build-and-inspect-packages, fix typo in guide #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/pages/guides/gha_pure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ later in the upload action for the release job, as well).
> ```
>
> The artifact it produces is named `Packages`, so that's what you need to use
> later to publish.
> later to publish. This will be used instead of the manual steps below.

And then, you need a release job:

Expand Down Expand Up @@ -201,6 +201,7 @@ name: CD

on:
workflow_dispatch:
pull_request:
push:
branches:
- main
Expand Down Expand Up @@ -229,7 +230,7 @@ jobs:
steps:
- uses: actions/download-artifact@v3
with:
name: artifact
name: Packages
path: dist

- uses: pypa/gh-action-pypi-publish@release/v1
Expand All @@ -246,6 +247,7 @@ name: CD

on:
workflow_dispatch:
pull_request:
push:
branches:
- main
Expand Down
12 changes: 2 additions & 10 deletions ...roject_name}}/.github/workflows/{% if cookiecutter.__type!='compiled' %}cd.yml{% endif %}
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,7 @@ jobs:
with:
fetch-depth: 0

- name: Build sdist and wheel
run: pipx run build

- uses: actions/upload-artifact@v3
with:
path: dist

- name: Check products
run: pipx run twine check dist/*
- uses: hynek/build-and-inspect-python-package@v1

publish:
needs: [dist]
Expand All @@ -49,7 +41,7 @@ jobs:
steps:
- uses: actions/download-artifact@v3
with:
name: artifact
name: Packages
path: dist

- uses: pypa/gh-action-pypi-publish@release/v1
Expand Down