Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update "cd" workflow adding "test_sdist" and "check_dist" jobs #379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Update "cd" workflow adding "test_sdist" and "check_dist" jobs #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
47 changes: 46 additions & 1 deletion ...roject_name}}/.github/workflows/{% if cookiecutter.__type=='compiled' %}cd.yml{% endif %}
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,51 @@ jobs:
name: cibw-sdist
path: dist/*.tar.gz

test_sdist:
name: Test SDist with python ${{ matrix.python }}
needs: [make_sdist]
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python: ["3.8", "3.12"]

steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
name: Install Python ${{ matrix.python }}
with:
python-version: ${{ matrix.python }}

- name: Install dependencies
run: |
pip install pytest pytest-cov
Copy link
Author

@jcfr jcfr Feb 17, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependencies could also be automatically extracted using approach like the one suggested in pypa/pip#8049 (comment) or we could wait for pypa/pip#11440 to be integrated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what I am using in an other project:

          # Waiting pip supports `--only-deps=test`, explicitly extract the test dependencies
          # See https://github.com/pypa/pip/issues/11440
          pip install yq
          tomlq -r '.project."optional-dependencies".test[]' pyproject.toml | xargs -d '\n' pip install


- uses: actions/download-artifact@v4
with:
name: cibw-sdist
path: dist

- name: Install SDist
run: |
pip -V
pip install dist/*.tar.gz
rm -rf dist

- name: Test installed SDist
run: pytest ./tests

check_dist:
name: Check dist
needs: [build_wheels, make_sdist, test_sdist]
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v4
with:
path: all

- run: pipx run twine check --strict all/*/*

build_wheels:
name: {% raw %}Wheel on ${{ matrix.os }}{% endraw %}
runs-on: {% raw %}${{ matrix.os }}{% endraw %}
Expand All @@ -52,7 +97,7 @@ jobs:
path: wheelhouse/*.whl

upload_all:
needs: [build_wheels, make_sdist]
needs: [check_dist]
environment: pypi
permissions:
id-token: write
Expand Down