Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import-mode #233

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Support import-mode #233

merged 4 commits into from
Nov 6, 2023

Conversation

flying-sheep
Copy link
Contributor

Fixes #231

pllim
pllim reviewed Nov 3, 2023
View reviewed changes
tests/test_doctestplus.py Outdated Show resolved Hide resolved
@pllim pllim added this to the 1.1.0 milestone Nov 3, 2023
@pllim pllim added the bug label Nov 3, 2023
@pllim
Copy link
Contributor

pllim commented Nov 3, 2023

Thanks! Please also add a change log entry to https://github.com/scientific-python/pytest-doctestplus/blob/main/CHANGES.rst

pllim
pllim approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! But I'll let Brigitta decide if we can use "Squash and Merge" or you have to do it manually.

@pllim pllim requested a review from bsipocz November 3, 2023 15:08
@bsipocz
Copy link
Member

bsipocz commented Nov 6, 2023

changelog conflict, so I'm going ahead and do a squash while rebasing

bsipocz
bsipocz approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flying-sheep!

@bsipocz bsipocz merged commit b002adc into scientific-python:main Nov 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@bsipocz bsipocz bsipocz approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Doesn’t respect --import-mode
3 participants
@flying-sheep @pllim @bsipocz