Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment issues #192

Closed
tupui opened this issue Aug 10, 2022 · 1 comment · Fixed by #230
Closed

Alignment issues #192

tupui opened this issue Aug 10, 2022 · 1 comment · Fixed by #230
Assignees
@alphapapa

Comments

@tupui
Copy link
Member

tupui commented Aug 10, 2022 •
edited
Loading

I have noticed a few alignment issues on the footer and hero banner. Interestingly it seems fine on SciPy's page for instance. Maybe this just happens if elements are too big.

The footer is not centered if you resize the window to a small screen. Some elements do not wrap and just disappear. Lastly, the vertical alignment is not correct and I think we should reduce the footer size.
Screenshot 2022-08-05 at 19 42 02

There is no padding on the hero banner when resized
Screenshot 2022-08-05 at 19 42 40
@alphapapa
Copy link
Contributor

@tupui Thanks. Assigning to myself and will investigate.

@alphapapa alphapapa self-assigned this Apr 26, 2023
alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this issue May 9, 2023
@alphapapa
Fix: (layouts/partials/footer.html) Alignment
592d1b6 
This removes the hard-coded padding-left property from these UL
elements.  It fixes the alignment in a narrow (e.g. smartphone)
display, and in a wide (e.g. desktop) display, the difference is
insignificant and no worse.

Fixes scientific-python#192.  Thanks to Pamphile Roy (@tupui) for reporting.
@alphapapa alphapapa mentioned this issue May 9, 2023
Merged
alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this issue May 9, 2023
@alphapapa
Fix: (assets/theme-css/styles.css) Margin around hero title
d22bfb0 
Only for narrow viewports.

Fixes scientific-python#192.  Thanks to Pamphile Roy (@tupui) for reporting.
alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this issue May 9, 2023
@alphapapa
Fix: (assets/theme-css/styles.css) Margins for hero title, logo
1a585a6 
Fixes scientific-python#192.  Thanks to Pamphile Roy (@tupui) for reporting.
@alphapapa alphapapa mentioned this issue May 9, 2023
Open
jarrodmillman pushed a commit that referenced this issue May 18, 2023
@alphapapa
Fix: (layouts/partials/footer.html) Alignment (#230)
3a845c4 
* Fix: (layouts/partials/footer.html) Alignment

This removes the hard-coded padding-left property from these UL
elements.  It fixes the alignment in a narrow (e.g. smartphone)
display, and in a wide (e.g. desktop) display, the difference is
insignificant and no worse.

Fixes #192.  Thanks to Pamphile Roy (@tupui) for reporting.

* Fix: (assets/theme-css/styles.css) Margins for hero title, logo

Fixes #192.  Thanks to Pamphile Roy (@tupui) for reporting.

* Meta: (assets/theme-css/styles.css) Local variable

For indentation in Emacs's css-mode.  This way Emacs doesn't want to
change the indentation from the file's current 2-spaces setting.

* Change: (assets/theme-css/styles.css) "Hero" improvements

See <#230>.

* Change: (assets/theme-css/styles.css) Logo on small screens

This enlarges the logo on screens above 400px wide, and on screens
that wide or narrower, the logo is displayed below the text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphapapa alphapapa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: (layouts/partials/footer.html) Alignment alphapapa/scientific-python-hugo-theme
2 participants
@alphapapa @tupui