Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydata-sphinx-theme admonition styling #301

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

jarrodmillman
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 83879a5
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/6532e757781632000858a040
😎 Deploy Preview https://deploy-preview-301--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96
Accessibility: 98
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jarrodmillman jarrodmillman added the type: Enhancement New feature or request label Oct 19, 2023
@jarrodmillman jarrodmillman marked this pull request as draft October 19, 2023 15:46
@jarrodmillman jarrodmillman force-pushed the pst-admonitions branch 5 times, most recently from ac4d9a9 to b3e4ac5 Compare October 19, 2023 19:19
@alphapapa
Copy link
Contributor

@jarrodmillman Would you like me to continue working on this? e.g. we could remove the Font Awesome icons, or we could add Font Awesome to the theme, like in pydata-sphinx-theme, so those icons could be used to replace the information circle character.

@jarrodmillman jarrodmillman mentioned this pull request Oct 20, 2023
@jarrodmillman jarrodmillman marked this pull request as ready for review October 20, 2023 21:05
@jarrodmillman jarrodmillman merged commit 68483d4 into scientific-python:main Oct 20, 2023
5 checks passed
@jarrodmillman jarrodmillman deleted the pst-admonitions branch October 20, 2023 21:06
@jarrodmillman jarrodmillman added this to the 0.3 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants