Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use box-shadow feature boxes #344

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

jarrodmillman
Copy link
Member

Close #341.

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit adf8ece
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/654147b41bf42e000842eca6
😎 Deploy Preview https://deploy-preview-344--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80
Accessibility: 100
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jarrodmillman jarrodmillman added the type: Enhancement New feature or request label Oct 31, 2023
@jarrodmillman
Copy link
Member Author

2023-10-31T08:31:20,227384747-07:00

2023-10-31T08:33:57,703782225-07:00

@jarrodmillman
Copy link
Member Author

2023-10-31T08:36:24,060771718-07:00

It is different than it was in v0.1, but it is more similar than v0.3 of the theme and all the text is displayed.
2023-10-31T08:39:23,349048264-07:00

@jarrodmillman
Copy link
Member Author

I better aligned the hero banner in 8bfebed.
2023-10-31T08:47:49,770944756-07:00

border: 0.02em solid var(--pst-color-border);
box-shadow:
0 0.2rem 0.5rem var(--pst-color-shadow),
0 0 0.0625rem var(--pst-color-shadow) !important;
Copy link
Member

@stefanv stefanv Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this !important necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied it from pst. I will investigate whether we need it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.

@stefanv stefanv merged commit 5de2ee4 into scientific-python:main Oct 31, 2023
6 checks passed
@jarrodmillman jarrodmillman added this to the 0.3 milestone Oct 31, 2023
@jarrodmillman jarrodmillman modified the milestones: 0.3, 0.4 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key boxes overflow incorrectly
2 participants