Fix github action syntax in proposed SPEC 5 #187
Conversation
| @@ -50,10 +50,10 @@ workflow" add the following lines as an additional step: | |||
|
|
|||
| ``` | |||
| - name: Upload wheel | |||
| uses: scientific-python/upload-nightly-wheel | |||
| uses: scientific-python/upload-nightly-action@main | |||
There was a problem hiding this comment.
Can we suggest using releases rather than main? Or we are foreseeing a lot of changes that would mean constant changes in the version in downstream config painful?
There was a problem hiding this comment.
Hmm, sure I don't have strong opinions about this. We do have a 0.1.0 release right now, but that's only tested with ipython and networkx right now, should we wait for some other package to try this out?
There was a problem hiding this comment.
I'm just wondering about best practices. Arguably, if it's points to main the action may have changed to do something entirely different. However, the same people who can push to main could rewrite a tag, too, so overall it probably doesn't matter security-wise.
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
|
Yeah, still figuring things out... lets get that in. |
No description provided.