Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest: replace existing process #57

Merged
merged 1 commit into from Mar 2, 2023

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Mar 2, 2023

@mattip Is this enough to address your gdb issue, or do I need to try something a bit smarter?

@mattip
Copy link
Contributor

mattip commented Mar 2, 2023

LGTM, thanks.

Details about how I verified it works

From a clean checkout of numpy, before that change:

$ python3.9 -m venv /tmp/venv3
$ . /tmp/venv3/bin/activate
$ python -m pip install -r build_requirements.txt
$ python -m pip install -r test_requirements.txt
$ python dev.py build -- --debug
$ gdb --args python dev.py test -- numpy/core/tests/test_ufunc.py
(gdb) b ufunc_at
Function "ufunc_at" not defined.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (ufunc_at) pending.
(gdb) r
Starting program: /tmp/venv3/bin/python dev.py test -- numpy/core/tests/test_ufunc.py
...
# tests pass without hitting the breakpoint

Running the gdb sesion after the change, I hit the breakpoint and can debug.

@stefanv stefanv merged commit 0615d20 into scientific-python:main Mar 2, 2023
4 checks passed
@jarrodmillman jarrodmillman added this to the 0.1 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants