fix: Counting of nested AIS details in HTML export #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarstenWickner
commented
Jun 13, 2023
| @@ -197,7 +197,7 @@ span.detail-end { float: right; } | |||
| </xsl:if> | |||
| </td> | |||
| <td class="number"> | |||
| <xsl:value-of select="count(.//ais:Detail//ais:Token)" /> | |||
| <xsl:value-of select="count(.//ais:Detail[@code]/ais:Token)" /> | |||
There was a problem hiding this comment.
Overall token count on the results table.
Fix 1: Ensure no double-counting of tokens that are within nested detail annotations. (removing one slash /)
Fix 2: Exclude tokens from the total count when they are surrounded by an annotated detail but don't have a specific category assigned to themselves. (checking for code attribute's existence)
| @@ -241,7 +241,7 @@ span.detail-end { float: right; } | |||
| <xsl:value-of select="concat(' ',@code,' ')" /> | |||
| </xsl:for-each> | |||
| </xsl:variable> | |||
| <xsl:value-of select="count($interview//ais:Detail[contains($childCodes,concat(' ',@code,' '))])" /> | |||
| <xsl:value-of select="count($interview//ais:Detail[@code and contains($childCodes,concat(' ',@code,' '))])" /> | |||
There was a problem hiding this comment.
Count of annotated details in parent category: sum of annotations for child categories
Fix 3: Exclude token sections surrounded by an annotated detail that don't have a specific category assigned to themselves. (checking for code attribute's existence)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count of AIS details in the HTML export is showing too high values if there are nested details I’ve attached a minimal example, to illustrate it, also with the generated HTML file after the fix I made.
For reference, attached a minimal example AIS project and erroneous HTML export result.
reproduce-bug.zip