Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize iiif print models for specs #101

Open
ShanaLMoore opened this issue Feb 6, 2023 · 0 comments
Open

Normalize iiif print models for specs #101

ShanaLMoore opened this issue Feb 6, 2023 · 0 comments
Assignees
@laritakr
Labels
IiifPrint

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Feb 6, 2023 •
edited
Loading

ref #43 #77

create spec model and configuration for the specs we run. clean up spec helper.
jeremyf added a commit that referenced this issue Feb 6, 2023
@jeremyf
Moving FileSet definition to specs
66f0077 
Before this commit, the file_set.rb was something that all applications
would load into their production code.  Ideally, we don't want to do
that for the primary reason that our file_set directly inherits from
`ActiveFedora::Base`.  If a downstream FileSet were to not inherit from
`ActiveFedora:Base` we would have a mismatch error.

With this commit, we're saying that the IIIF print gem will require a
FileSet that conforms to the PCDM expectations.  But we don't dictate
it's implementation details in the downstream application.  We instead
dictate those implementation details in the test application.

Related to:

- #101
@jeremyf jeremyf mentioned this issue Feb 6, 2023
Closed
jeremyf added a commit that referenced this issue Feb 6, 2023
@jeremyf
Moving FileSet and NewspaperIssue definition to specs
864bc16 
Before this commit, the these files were something that all applications
would load into their production code.  Ideally, we don't want to do
that for the two reasons:

- First, not everyone wants a NewspaperIssue model in their application

- Second the file_set, as implemented, directly inherits from
  `ActiveFedora::Base`.  If a downstream FileSet were to not inherit
  from `ActiveFedora:Base` we would have a mismatch error.

With this commit, we're saying that the IIIF print gem will require a
FileSet that conforms to the PCDM expectations.  But we don't dictate
it's implementation details in the downstream application.  We instead
dictate those implementation details in the test application.

Related to:

- #101
jeremyf added a commit that referenced this issue Feb 6, 2023
@jeremyf
Moving FileSet and NewspaperIssue definition to specs
ac4d3e1 
Before this commit, these files were something that all applications
would load into their production code.  Ideally, we don't want to do
that for the two reasons:

- First, not everyone wants a NewspaperIssue model in their application

- Second the file_set, as implemented, directly inherits from
  `ActiveFedora::Base`.  If a downstream FileSet were to not inherit
  from `ActiveFedora:Base` we would have a mismatch error.

With this commit, we're saying that the IIIF print gem will require a
FileSet that conforms to the PCDM expectations.  But we won't dictate
its implementation details in the downstream application.  We instead
dictate those implementation details in the test application.

Also we will not force downstream Hyrax implementations to include a
NewspaperIssue model.

Related to:

- #101
@jeremyf jeremyf mentioned this issue Feb 6, 2023
Merged
@jeremyf jeremyf removed their assignment May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laritakr laritakr

Labels
IiifPrint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeremyf @ShanaLMoore @laritakr @jillpe