Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIIF Print and AV Interplay and Per Tenant Options #274

Open
jeremyf opened this issue Aug 11, 2023 · 0 comments
Open

IIIF Print and AV Interplay and Per Tenant Options #274

jeremyf opened this issue Aug 11, 2023 · 0 comments

Comments

@jeremyf
Copy link
Contributor

jeremyf commented Aug 11, 2023

There's issues in the relationship between IIIF Print, AV, and Hyku. For now this is a place holder for future way finding.

There is a conflict between the IiifPrint and Hyrax::IiifAv gems;
namely they both have strong opinions about how to sniff out if we
should use the iiif_viewer?. Compounding this, is that IiifPrint
decorates Hyrax::WorkShowPresenter and Hyku extends
Hyrax::WorkShowPresenter then includes
Hyrax::IiifAv::DisplaysIiifAv.

The end result is that the logic to determine if we should show pages
split from the PDF is never called. Yet, if we were to solely use
IiifPrint we'd ignore rendering audio and vidoe in the iiif viewer.

So this commit peels that back so that we're using the logic (brought
forward by IiifPrint) but ensuring our Hyku presenters are using that
logic.

Why move the logic out of the Hyku instance and into a module? Because
that module contains the per-tenant antics of IiifPrint and its PDF
relationship.

There is larger work to do in regards to incorporating this logic into
IiifPrint and the Hyrax::IiifAv gem.

Related to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant