Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Louisville app/presenters/hyrax/work_show_presenter_decorator has several iiif / nesting items in it #36

Closed
Tracked by #19
kirkkwang opened this issue Dec 14, 2022 · 6 comments

Comments

@kirkkwang
Copy link
Contributor

kirkkwang commented Dec 14, 2022

ref: https://github.com/scientist-softserv/louisville-hyku/blob/42a0fc837fd9ef4832a9741731672200e0097305/app/presenters/hyrax/work_show_presenter_decorator.rb

Compare to hyrax/hyku's version to spot the differences.

parent/child relationships should display properly.

This view file uses this method which will probably need to be moved over as well

@jillpe jillpe changed the title Louisville app/presenters/hyrax/work_show_presenter has several iiif / nesting items in it Louisville app/presenters/hyrax/work_show_presenter_decorator has several iiif / nesting items in it Jan 3, 2023
@kirkkwang kirkkwang self-assigned this Jan 9, 2023
@kirkkwang
Copy link
Contributor Author

kirkkwang commented Jan 9, 2023

Hyku's version inherits from Hyrax's version, no conflicts spotted

@jillpe
Copy link

jillpe commented Jan 16, 2023

This can be broken down into additional tickets:

  1. allow for configuration of sort order
  2. allow for configuration of filtering of members
  3. good recommended default

@ShanaLMoore
Copy link
Contributor

This ticket may not be needed. By default, LaRita's work #11 should handle sorting ordered_members, which is how the items should get displayed.

We may consider offering a configuration for sort, so that the client can choose what they want instead.

@ShanaLMoore
Copy link
Contributor

cc @kirkkwang Is this ticket about giving users to configure a way for items to get presented in the UV?

@kirkkwang
Copy link
Contributor Author

I believe so, that's the item partial in LV is supposed to do.

It also deals with showing the UV even if the parent image doesn't have a fileset. This file from LV would also need to be added to make it work.

related issue #76

@jillpe
Copy link

jillpe commented Jan 24, 2023

closed - duplicate of #76

@jillpe jillpe closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants