-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make CreateIssuePageJob
more generic
#11
Comments
CreateIssuePageJob
more generic
renamed to CreatePagesJob per LaRita. Currently the functionality of this job is all commented out. |
maybe reference and compare it to ConvertPdftoJpg job in LV. |
Test comment for @ShanaLMoore |
Note: Per discussion at 12/14 standup, this job will be based on the Newspaper gem's job, where one or more PDFs are added to a parent work, and processing will split each PDF into individual works with multiple FileSets for each page of the PDF. |
#32 depends on this ticket |
TODO: Question about tiffs @kirkkwang to help change tiffs to jpgs for now to unblock LaRita. We will revisit this when we have Rob's attention We will split this off to its own ticket. |
TODO: @laritakr to add QA instructions with a demo/screenshots to this ticket. We will spin off the specs for this work in a separate ticket, to unblock other iiif_print work. |
Ref issue #11 * Create jobs to split pdfs into child works, using Hyrax's BatchCreateJob and CreateChildWork * Create job to add child works to parent work * Create services to split PDFs into TIFFs * Migration to create IiifPrintPendingRelationships to track child works and add to parent * Allow functionality to be added to work models by including configuration `include IiifPrint.model_configuration(pdf_split_child_model: GenericWork)` Specs are still pending completion at this point.
To test via hyku, create a Generic Work with a PDF file. This can be done via the UI or via Bulkrax. (If via bulkrax, the file name must be in the same CSV row as the work itself). Other work types are not configured to split PDFs, and should behave normally. You should see:
Note:
|
|
@laritakr did this get QA'd? I see it moved to this column but don't see notes detailing the results (unless the previous comment got edited with them?). |
Kirk and I did some QA ourselves, but neither of us added notes. Jeremy merged
it yesterday because it had code we needed for spec work, which is why I
moved it, but you're right that additional QA with notes is probably
beneficial.
|
Note that the relationship job is delayed 10 minutes, so there can be a lag before the child works appear on the parent. |
Summary
CreateIssuePageJob should be more generic.
class method that should take an argument of what type of class it should split it into. ie
#split_pdf_into("Book")
Currently the newspaper gem doesn't give you a choice. All created children are type
NewspaperPage
.ref: https://github.com/samvera-labs/newspaper_works/blob/bbe8736b0cf622d9c2577faf7a6f0a4e8dd1452c/lib/newspaper_works/ingest/newspaper_issue_ingest.rb#L41
Acceptance Criteria
CreateIssuePageJob
is more generic#split_pdf_into
takes an argument of a work typeThe text was updated successfully, but these errors were encountered: