Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper tests for is_continuous #3

Open
kwinkunks opened this issue Aug 25, 2022 · 2 comments
Open

Proper tests for is_continuous #3

kwinkunks opened this issue Aug 25, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers testing Issue about testing

Comments

@kwinkunks
Copy link
Member

The if/else stuff in this function feels pretty fragile. There is almost certainly a better way to do it.

Good first issue if you like maths and/or code testing.

@kwinkunks kwinkunks added enhancement New feature or request good first issue Good for newcomers labels Aug 25, 2022
@kwinkunks
Copy link
Member Author

Hm, this still misses the Facies column in the classic Hugoton dataset.

@kwinkunks
Copy link
Member Author

See this thread: https://stackoverflow.com/questions/35826912/what-is-a-good-heuristic-to-detect-if-a-column-in-a-pandas-dataframe-is-categori

This was failing too:

a = np.repeat(np.arange(0, 5), 10)
rf.is_continuous(a)

(Is discrete, but was saying continuous because sample size too small. Now using all samples unless more than 10,000 samples, then use 10,000.)

@kwinkunks kwinkunks added the testing Issue about testing label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers testing Issue about testing
Projects
None yet
Development

No branches or pull requests

1 participant