Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper feedback #89

Closed
jsheunis opened this issue Dec 3, 2023 · 1 comment
Closed

JOSS paper feedback #89

jsheunis opened this issue Dec 3, 2023 · 1 comment

Comments

@jsheunis
Copy link

jsheunis commented Dec 3, 2023

Hi @kwinkunks

The JOSS paper itself is nicely written, well done. Here are some minor feedback points:

  • Based on the checklist "Do the authors describe how this software compares to other commonly-used packages", you do provide examples of similar packages in lines 61-65, but you don't elaborate on how redflag compares to these. I would add a couple of sentences to explain differences.

  • Typo in line 50:

    There are two kinds of scikit-learn transformer

    --> There are two kinds of scikit-learn transformers:

  • Line 64-65, typo, and more info needed:

    Finally, evidently provides on a Jupyter interface with lots of plots.

    --> Finally, evidently provides on a Jupyter interface with lots of plots.
    Also, "lots of plots" sounds very vague, perhaps you could provide a bit more detail about what this package provides.


Ping openjournals/joss-reviews#6065

kwinkunks added a commit that referenced this issue Dec 9, 2023
@kwinkunks
Copy link
Member

Thanks for the feedback. I think I addressed these in the latest draft.

  • Added this sentence:

    In comparison, Redflag is easier to set up and use
    than great_expectations and pandera, and while it is compatible with
    Pandas DataFrames and Jupyter it does not depend on them.

  • Reworded sentence:

    The scikit-learn transformers are of two kinds:

  • Fixed typo and clarified:

    Finally,
    evidently provides a graphical
    dashboard for Jupyter.

kwinkunks added a commit that referenced this issue Dec 9, 2023
kwinkunks added a commit that referenced this issue Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants