-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper feedback #89
Comments
Thanks for the feedback. I think I addressed these in the latest draft.
|
Hi @kwinkunks
The JOSS paper itself is nicely written, well done. Here are some minor feedback points:
Based on the checklist "Do the authors describe how this software compares to other commonly-used packages", you do provide examples of similar packages in lines 61-65, but you don't elaborate on how
redflag
compares to these. I would add a couple of sentences to explain differences.Typo in line 50:
--> There are two kinds of scikit-learn transformers:
Line 64-65, typo, and more info needed:
--> Finally, evidently provides
ona Jupyter interface with lots of plots.Also, "lots of plots" sounds very vague, perhaps you could provide a bit more detail about what this package provides.
Ping openjournals/joss-reviews#6065
The text was updated successfully, but these errors were encountered: