Reuse an error behaviour across two pages #3263

sciety · May 23, 2024 · 83b833a · 83b833a
1 parent 9c18a57
commit 83b833a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 18 deletions.
diff --git a/src/read-side/html-pages/create-page-from-params.ts b/src/read-side/html-pages/create-page-from-params.ts
@@ -9,7 +9,12 @@ import { toHtmlFragment } from '../../types/html-fragment';
 
 export const toNotFound = (): ErrorPageBodyViewModel => toErrorPageBodyViewModel({
   type: DE.notFound,
-  message: toHtmlFragment('Page not found'),
+  message: toHtmlFragment('Page not found.'),
+});
+
+export const toUnavailable = (): ErrorPageBodyViewModel => toErrorPageBodyViewModel({
+  type: DE.unavailable,
+  message: toHtmlFragment('Sorry, something went wrong. Please try again later.'),
 });
 
 type GeneratePage<P> = (params: P) => TE.TaskEither<ErrorPageBodyViewModel, HtmlPage>;

diff --git a/src/read-side/html-pages/groups-page/groups-page.ts b/src/read-side/html-pages/groups-page/groups-page.ts
@@ -4,25 +4,19 @@ import { pipe } from 'fp-ts/function';
 import { constructViewModel } from './construct-view-model/construct-view-model';
 import { Dependencies } from './construct-view-model/dependencies';
 import { renderGroups } from './render-groups';
-import * as DE from '../../../types/data-error';
-import { ErrorPageBodyViewModel, toErrorPageBodyViewModel } from '../../../types/error-page-body-view-model';
-import { toHtmlFragment } from '../../../types/html-fragment';
+import { ErrorPageBodyViewModel } from '../../../types/error-page-body-view-model';
+import { toUnavailable } from '../create-page-from-params';
 import { HtmlPage, NotHtml, toHtmlPage } from '../html-page';
 import { renderGroupCard } from '../shared-components/group-card';
 
-const renderErrorPage = (error: DE.DataError): ErrorPageBodyViewModel => toErrorPageBodyViewModel({
-  type: error,
-  message: toHtmlFragment('We\'re having trouble accessing search right now, please try again later.'),
-});
-
 type GroupsPage = TE.TaskEither<ErrorPageBodyViewModel, HtmlPage>;
 
 export const groupsPage = (dependencies: Dependencies): GroupsPage => pipe(
   constructViewModel(dependencies),
   TE.map(RA.map(renderGroupCard)),
   TE.map(renderGroups),
   TE.bimap(
-    renderErrorPage,
+    toUnavailable,
     (content) => toHtmlPage({
       title: 'Groups',
       content,

diff --git a/src/read-side/html-pages/save-article-form-page/save-article-form-page.ts b/src/read-side/html-pages/save-article-form-page/save-article-form-page.ts
@@ -6,15 +6,8 @@ import { constructViewModel } from './construct-view-model';
 import { Dependencies } from './dependencies';
 import { paramsCodec } from './params';
 import { renderAsHtml } from './render-as-html';
-import * as DE from '../../../types/data-error';
-import { toErrorPageBodyViewModel } from '../../../types/error-page-body-view-model';
-import { toHtmlFragment } from '../../../types/html-fragment';
 import { ConstructPage } from '../construct-page';
-
-const toUnavailable = () => toErrorPageBodyViewModel({
-  type: DE.unavailable,
-  message: toHtmlFragment('Sorry, something went wrong. Please try again later.'),
-});
+import { toUnavailable } from '../create-page-from-params';
 
 export const saveArticleFormPage = (
   dependencies: Dependencies,