Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docmaps: Support inputs in actions, and deprecate inputs in steps #3069

Closed
kevinrutherford opened this issue Mar 4, 2024 · 1 comment
Closed

Docmaps: Support inputs in actions, and deprecate inputs in steps #3069

kevinrutherford opened this issue Mar 4, 2024 · 1 comment
Labels
docmaps related to DocMaps API solo-work
Projects
Sciety

Comments

@kevinrutherford
Copy link
Collaborator

kevinrutherford commented Mar 4, 2024 •
edited

The standard is evolving such that the inputs are moving from steps into actions. The SDK has been updated (Docmaps-Project/docmaps#158) such that the inputs are supported in actions and also still provided (but deprecated) in steps to support legacy clients that haven't yet migrated to the new standard.

This ticket will make an equivalent change to Sciety's docmaps.
@kevinrutherford kevinrutherford created this issue from a note in Sciety (In progress) Mar 4, 2024
@kevinrutherford kevinrutherford added docmaps related to DocMaps API solo-work labels Mar 4, 2024
kevinrutherford added a commit that referenced this issue Mar 4, 2024
@kevinrutherford
Add inputs to actions and deprecate inputs in steps #3069
c3e0ac3
kevinrutherford added a commit that referenced this issue Mar 4, 2024
@kevinrutherford
Specify with tests that each action must have an input #3069
0071cde
kevinrutherford added a commit that referenced this issue Mar 4, 2024
@kevinrutherford
Define the docmap viewmodel in a place more consistent with other views
00455ca 
#3069
kevinrutherford added a commit that referenced this issue Mar 4, 2024
@kevinrutherford
Render inputs once and only once #3069
00e46c6
kevinrutherford added a commit that referenced this issue Mar 4, 2024
@kevinrutherford
Remove some uses of expect.objectContaining #3069
6188865
kevinrutherford added a commit that referenced this issue Mar 4, 2024
@kevinrutherford
Remove some more uses of expect.objectContaining #3069
e9d23b4
kevinrutherford added a commit that referenced this issue Mar 4, 2024
@kevinrutherford
Introduce shared specs to remove some test duplication #3069
b8ec10a
Sciety automation moved this from In progress to Done Mar 5, 2024
@kevinrutherford kevinrutherford moved this from Done to In progress in Sciety Mar 7, 2024
@LinaKind
Copy link
Collaborator

LinaKind commented Mar 7, 2024

Biorxiv and EuropePMC notified.

@LinaKind LinaKind closed this as completed Mar 7, 2024
Sciety automation moved this from In progress to Done Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docmaps related to DocMaps API solo-work
Projects
Sciety
Archived in project
Sciety
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinrutherford @LinaKind