Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out @Attr annotation usage #108

Closed
hinerm opened this issue Dec 5, 2013 · 1 comment
Closed

Refactor out @Attr annotation usage #108

hinerm opened this issue Dec 5, 2013 · 1 comment
Assignees
Milestone

Comments

@hinerm
Copy link
Member

hinerm commented Dec 5, 2013

The Attr sub-annotation in Plugin annotations is messy and was intended to be a last ditch effort.

In the primary use cases of Attr in SCIFIO, Filters and Translators, we really don't need the information BEFORE an instance of the corresponding class is made.

So we should refactor Filters and Translators to use API instead of static fields and Attrs, which is also then extensible.

This should be done in tandem with #20.

Also, Translators could then be SingletonServices and SingletonPlugins.

This change should also allow us to fully remove Annotation usage from tests (e.g., FilterTest).

@ghost ghost assigned hinerm Dec 5, 2013
@ctrueden
Copy link
Member

ctrueden commented Dec 5, 2013

FWIW, I did this just now for Tool plugins in ImageJ2. See imagej/ImageJ@3fc174b for details.

@hinerm hinerm closed this as completed in c343e83 Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants