Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DefaultPlatform.open() return quickly, always #1

Open
ctrueden opened this issue May 11, 2014 · 0 comments
Open

Make DefaultPlatform.open() return quickly, always #1

ctrueden opened this issue May 11, 2014 · 0 comments

Comments

@ctrueden
Copy link
Member

On MacOSX and Windows, open(url) will return immediately. On Linux, open(url) will immediately only if there was already a running web browser instance.

We might need to do something as hacky as trying to execute the launcher, waiting for 50ms and checking whether Process.exitValue() indicates that the executable was not found (it throws an IllegalThreadStateException if the process has not yet terminated). Probably it would be a good idea to wait a little bit longer to see whether it still wants to terminate with an error code, just in case the machine was busy.

This change is needed to make things behave consistently between platforms.

Migrated-From: http://trac.imagej.net/ticket/1419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant