Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use src/{package} layout #145

Merged
merged 1 commit into from Jun 2, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented May 24, 2021

This helps ensure what's being tested when installing the sdist or wheel and one wants to run tests on those installed packages on their own.

@mayeut mayeut mentioned this pull request May 24, 2021
@henryiii
Copy link
Contributor

henryiii commented May 29, 2021

Any thoughts, @jcfr or @thewtex? Otherwise I'd like to merge.

Personally, I'm already a huge fan of src layout, for the same reason as listed above; it's too easy to accidentally test the in-directory version instead of the installed version. src layout forces you to either use the packaging mechanisms or be completely intentional about running from a directory. This is really important if it is a built package.

@mayeut mayeut force-pushed the refactor-use-src-layout branch 4 times, most recently from cc453fe to beb1b64 Compare May 30, 2021 16:37
@henryiii henryiii merged commit 7361bd3 into scikit-build:master Jun 2, 2021
@jcfr
Copy link
Contributor

jcfr commented Jun 2, 2021

forces you to either use the packaging mechanisms or be completely intentional about running from a directory. This is really important if it is a built package.

Makes sense. Moving forward, I will adopt a similar structure for our projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants