Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump to manylinux 2010, add test #158

Closed
wants to merge 2 commits into from
Closed

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Nov 6, 2022

From #157. I've uploaded manually built 1.11.1 binaries for manylinux2010. This adds a test that shows the breakage, then adds the bump to 2010 which fixes it. Should we also ship manylinux1? I'd say no (in fact, I think I'd be fine to delete the old manylinux1 binaries for 1.11.1) - it's probably more likely that and old pip would get a broken binary than someone would need this on actual manylinux1.

I'd like to know why this broke - was is ninja, or is there some issue with the latest manylinux1? Maybe someone will investigate someday.

FYI, to build locally with a different manylinux, say for the 32-bit wheel:

git checkout 1.11.1
CIBW_MANYLINUX_I686_IMAGE=manylinux2010 pipx run cibuildwheel --only cp39-manylinux_i686

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii changed the title ci: add a test on the host for linux fix: bump to manylinux 2010, add test Nov 6, 2022
@mayeut
Copy link
Contributor

mayeut commented Nov 6, 2022

It's probably more likely that an old pip would get a broken binary than someone would need this on actual manylinux1

yep, for the past week that's around 5200 linux downloads with an old pip (<19.0) versus 50 downloads with 2.5 <= glibc < 2.12
Overall, that's 0.8% of downloads.

We could probably drop manylinux1 now. If the lack of a manylinux1 wheel is a problem, then a mix-in with manylinux1 wheels built with a statically linked libstdc++ (as done in #159 ) can be added.

I'd like to know why this broke - was is ninja, or is there some issue with the latest manylinux1? Maybe someone will investigate someday.

Given that manylinux1 has been EOL for some years now, nothing has changed (for the relevant issue). My best guess is that a code change in ninja triggered an already existing bug in devtoolset-2 (rather than libstdc++ breaking ABI compatibility which might still be a possibility).

@mayeut
Copy link
Contributor

mayeut commented Nov 26, 2022

@henryiii, since you approved #159, I merged that one and will close this one.

@mayeut mayeut closed this Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants