Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyodide support #715

Closed
henryiii opened this issue Apr 19, 2024 · 1 comment · Fixed by #717
Closed

Pyodide support #715

henryiii opened this issue Apr 19, 2024 · 1 comment · Fixed by #717

Comments

@henryiii
Copy link
Collaborator

#675 switched to using cmake -E capabilities. But Pyodide injects --fresh to all cmake commands, so this broke pyodide support. Until pyodide/pyodide#4704 is resolved and released, we should fall back to --version if this fails to fix pyodide.

@LecrisUT
Copy link
Collaborator

A quick recap on how the 2 projects are related? Injecting --fresh sound like it would break any cmake command, including cmake --build, how is that not broken before?

Oh they actually have specific checks for those :/

        # If it is a build/install command, or running a script, we don't do anything.
        if "--build" in line or "--install" in line or "-P" in line:

Looks like there are many other functionalities to include there than: https://cmake.org/cmake/help/latest/manual/cmake.1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants