Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prettier logging with config setting #40

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Nov 4, 2022

Not supported in setuptools mode. Will take some thought there.

To test this or similar things, you can run:

pipx run build --wheel
PIP_FIND_LINKS="dist" pipx run build --wheel tests/packages/simple_pyproject_ext -o dist -C scikit-build.log-level=NOTSET

tests/test_module_dir.py Outdated Show resolved Hide resolved
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #40 (4a2eaec) into main (c263f17) will decrease coverage by 0.07%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   92.63%   92.56%   -0.08%     
==========================================
  Files          41       42       +1     
  Lines        1304     1332      +28     
==========================================
+ Hits         1208     1233      +25     
- Misses         96       99       +3     
Impacted Files Coverage Δ
src/scikit_build_core/pyproject/init.py 82.35% <82.35%> (ø)
src/scikit_build_core/pyproject/sdist.py 100.00% <100.00%> (ø)
src/scikit_build_core/pyproject/wheel.py 96.82% <100.00%> (+0.15%) ⬆️
src/scikit_build_core/settings/cmake_model.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii
Copy link
Collaborator Author

henryiii commented Nov 5, 2022

@mayeut Something’s wrong with ninja on GHA. Just restarting this causes it to fail when it used to pass. I’ll try to look at it in the next day or two. We are supposed to be protecting against this, but if the ninja package itself was broken, that might cause this.

@mayeut
Copy link

mayeut commented Nov 5, 2022

@henryiii henryiii closed this Nov 6, 2022
@henryiii henryiii reopened this Nov 6, 2022
@henryiii henryiii marked this pull request as ready for review November 7, 2022 15:52
@henryiii henryiii merged commit 887757e into main Nov 7, 2022
@henryiii henryiii deleted the henryiii/feat/logging branch November 7, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants