Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update README to use modern GitHub admonition #641

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Feb 16, 2024

No description provided.

@jcfr jcfr requested a review from henryiii February 16, 2024 18:41
@LecrisUT
Copy link
Collaborator

Should have a way to convert github-style admonitions to myst-parser ones

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ab6373) 86.23% compared to head (ac5cad4) 86.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          63       63           
  Lines        3233     3233           
=======================================
  Hits         2788     2788           
  Misses        445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii
Copy link
Collaborator

We need some sort of plugin or official support. We should open an issue. There is a plugin for mkdocs.

@henryiii
Copy link
Collaborator

(There's also the PyPI readme, we could use fancy-pypi-readme to fix that one though)

@henryiii henryiii merged commit 9c6f6a3 into main Feb 17, 2024
53 checks passed
@henryiii henryiii deleted the jcfr-patch-1 branch February 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants