Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Lower pybind11 test dependency #691

Merged
merged 1 commit into from Apr 8, 2024

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Apr 8, 2024

Fedora does not have pybind11 2.12 yet, lowering the dependency a bit.

But regarding the bounding of the minimum, is the github CI testing both for minimum and latest? I only see this part, which doesn't rely on pyproject.toml

- name: Min requirements
run: pip install --constraint tests/constraints.txt .[test] ninja

Are there plans to automate that and use the versions from pyproject.toml?

As for distro testing, the test bounds are meaningless there since they are only used at build time, and it always picks up the distro packaged versions.

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@henryiii
Copy link
Collaborator

henryiii commented Apr 8, 2024

Yes, constraints.txt is removed in #679.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (c8be08c) to head (61ea3fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          64       64           
  Lines        3315     3315           
=======================================
  Hits         2861     2861           
  Misses        454      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 2596ad6 into scikit-build:main Apr 8, 2024
43 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants