Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support bools in config settings #712

Merged
merged 1 commit into from Apr 18, 2024
Merged

fix: support bools in config settings #712

merged 1 commit into from Apr 18, 2024

Conversation

henryiii
Copy link
Collaborator

Fix #707.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (68fc751) to head (aa8766a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files          68       68           
  Lines        3870     3870           
=======================================
  Hits         3180     3180           
  Misses        690      690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit f4d0cd7 into main Apr 18, 2024
44 of 49 checks passed
@henryiii henryiii deleted the henryiii/fix/boolcs branch April 18, 2024 06:50
@mgorny
Copy link

mgorny commented Apr 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean fields in config_settings cause traceback if passed booleans
2 participants