Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbound variable error #719

Merged
merged 1 commit into from Apr 21, 2024
Merged

fix: unbound variable error #719

merged 1 commit into from Apr 21, 2024

Conversation

henryiii
Copy link
Collaborator

Fix #718

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.93%. Comparing base (c3e8c06) to head (050e478).

Files Patch % Lines
src/scikit_build_core/program_search.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files          68       68           
  Lines        3881     3881           
=======================================
  Hits         3180     3180           
  Misses        701      701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator Author

Verified this works locally in a docker container.

@henryiii henryiii merged commit 2aabc74 into main Apr 21, 2024
42 of 45 checks passed
@henryiii henryiii deleted the henryiii-patch-2 branch April 21, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnboundLocalError when system cmake is installed using pip
1 participant