setup.py improvements #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused imports - Use with statements to ensure files are closed - Improve description - Add note for Python 3.5 support
|
✅ Build scikit-build 0.0.1.272 completed (commit c3e2969573 by @thewtex) |
|
So easy, I just had to change my name to JC ;) |
|
Will the real @scopatz please stand up? |
jcfr
added a commit
that referenced
this pull request
Jul 18, 2016
…58 See http://nose.readthedocs.io/en/latest/setuptools_integration.html?highlight=python%20setup.py%20test Suggested-by: Matt McCormick <matt.mccormick@kitware.com>
All set |
jcfr
added a commit
that referenced
this pull request
Jul 18, 2016
setup.py: Fix test command setting 'nose.collector' as test_suite See #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements when reviewing
setup.py.@scikit-build/developers I noticed there was a referenced mailing list that did not exist, so I created it. It is now here:
https://groups.google.com/forum/#!forum/scikit-build
Please let me know when you have signed up, and I will add you as an administrator.