Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rpm spec #937

Merged
merged 1 commit into from Apr 13, 2023
Merged

fix: Rpm spec #937

merged 1 commit into from Apr 13, 2023

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Apr 13, 2023

%pypi_name was incorrect

Caught this because it failed to make a PR downstream. I will edit downstream as well, so no need for a new release for this.

Closes #936

- %pypi_name was incorrect
- forgot to add rpmlintrc
- create PR only for rawhide
  There is an issue where commits diverge making branch tracking more complicated

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #937 (8a86352) into main (36fe02a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files          31       31           
  Lines        1558     1558           
  Branches      343      343           
=======================================
  Hits         1343     1343           
  Misses        152      152           
  Partials       63       63           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii merged commit 84c7e4c into scikit-build:main Apr 13, 2023
19 checks passed
@LecrisUT LecrisUT deleted the rpm-spec branch April 14, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[packit] Propose downstream failed for release 0.17.1
2 participants