docs: GNU symbol visibility option #994
Conversation
aaron-bray
force-pushed
the
856-Document-SKBUILD_GNU_SKIP_LOCAL_SYMBOL_EXPORT_OVERRIDE
branch
4 times, most recently
from
2e7b2d2
to
76d8540
Compare
| `CMake option <https://scikit-build.readthedocs.io/en/latest/usage.html#cmake-configure-options>`_ | ||
| or | ||
| `setup.py option <https://scikit-build.readthedocs.io/en/latest/usage.html#scikit-build-options>`_. | ||
|
|
There was a problem hiding this comment.
| Note that for Python >= 3.9, setting the option `SKBUILD_GNU_SKIP_LOCAL_SYMBOL_EXPORT_OVERRIDE` to `ON` allow to ... |
It would be nice to further improve to provide some historical contest based on the summary available at #703 (comment)
There was a problem hiding this comment.
I added a little more detail as to how this works and on what systems.
aaron-bray
force-pushed
the
856-Document-SKBUILD_GNU_SKIP_LOCAL_SYMBOL_EXPORT_OVERRIDE
branch
from
76d8540
to
a98311f
Compare
aaron-bray
force-pushed
the
856-Document-SKBUILD_GNU_SKIP_LOCAL_SYMBOL_EXPORT_OVERRIDE
branch
from
06ab36d
to
2410b1c
Compare
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 33 33
Lines 1587 1587
Branches 351 351
=======================================
Hits 1369 1369
Misses 155 155
Partials 63 63 |
| Controlling exported symbol visibility | ||
| -------------------------------------- | ||
|
|
||
| When using a GNU based compiler on Linux, scikit-build will reduce the binary size by removing all the native exported methods. |
There was a problem hiding this comment.
This is part of PythonExtensions, not all of scikit-build, right? Most or all pybind11 and nanobind projects do not use PythonExtensions. Also, FindPythonInterp and FindPythonLibs is being removed (sort-of) from CMake 3.27; users using FindPython won't be affected by this variable either, I believe.
There was a problem hiding this comment.
@jcfr is there another caveot I am missing as to when this would be used?
Address issue #856