Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Rule Calculation Order for Intermediaries #76

Closed
jsexauer opened this issue Feb 13, 2016 · 2 comments
Closed

Improvements to Rule Calculation Order for Intermediaries #76

jsexauer opened this issue Feb 13, 2016 · 2 comments

Comments

@jsexauer
Copy link
Collaborator

The current way the control module figures out the order to process rules is based on if the terms that are in the predicate of the rule have been fully calculated at least once. This is not a good implementation because:

  • It produces inconsistent results when multiple rules drive the same variable's term. Eg:
rule1 = fuzz.Rule(service['good'], tip['good'])
rule2 = fuzz.Rule(quality['good'], tip['good'])
  • It produces inconsistent results when multiple rules drive the same variable and the membership functions of the term overlaps. Eg:
tip['good'] = fuzz.trimf(tip.universe, [13, 25, 25])
tip['fair'] = fuzz.trimf(tip.universe, [10, 20, 25]) # Exaggerated overlap in membership
rule1 = fuzz.Rule(service['good'], tip['good'])
rule2 = fuzz.Rule(quality['good'], tip['fair'])

Note that these limitations only affect intermediary variables.

A better approach is to ensure all rules which drive the input side of an intermediary (regardless of term) are calculated before any rules which use the intermediary in the predicate.

jsexauer added a commit to jsexauer/scikit-fuzzy that referenced this issue Feb 15, 2016
@JDWarner
Copy link
Collaborator

Closing as I believe this was addressed in #79. Feel free to reopen if this remains an issue.

@nilayrox18
Copy link

sir i am getting what you are saying but my issue is arise when i pass my
input to a system..

tipping.input['quality'] = 6.5
it take s quality as a index and show error like 'ValuesView' does not
support indexing....

please fix this sir..

On Fri, Mar 11, 2016 at 11:30 PM, Josh Warner notifications@github.com
wrote:

Closing as I believe this was addressed in #79
#79. Feel free to
reopen if this remains an issue.


Reply to this email directly or view it on GitHub
#76 (comment)
.

Mr. Nilay S. Shah
M.Tech ICT *
*Contact no : +91-8866319714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants