Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Add precomit GitHub Action #35

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Add precomit GitHub Action #35

merged 2 commits into from
Mar 29, 2020

Conversation

henryiii
Copy link
Member

Follow up to #33.

@henryiii henryiii changed the title Add precomit Add precomit GitHub Action Mar 29, 2020
@jpivarski
Copy link
Member

I'm willing to accept this. Let me know when you're done and I'll press "merge."

@henryiii
Copy link
Member Author

Just bumped a few versions (v2 checkout is faster, but sadly doesn't support submodules - not needed for pre-commit). Ready to merge.

@jpivarski jpivarski merged commit 3dcafdd into master Mar 29, 2020
@LovelyBuggies
Copy link
Collaborator

LovelyBuggies commented Mar 30, 2020

@henryiii Great, you have done exactly what I want for aghast. But plz let me know once you have overcome the problem at scikit-hep/vector#9 (comment) in scikit-hep/vector#9 and added conda GitHub Actions setup for aghast. Then I'll put all pip requirements to conda env.yml to distinguish them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants