Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexForm roundtrip to json fails for i32/u32 #231

Closed
nsmith- opened this issue May 3, 2020 · 0 comments · Fixed by #232
Closed

IndexForm roundtrip to json fails for i32/u32 #231

nsmith- opened this issue May 3, 2020 · 0 comments · Fixed by #232
Labels
bug (unverified) The problem described would be a bug, but needs to be triaged

Comments

@nsmith-
Copy link
Contributor

nsmith- commented May 3, 2020

Because of the typo here: https://github.com/scikit-hep/awkward-1.0/blob/6db9f5996d09e7ee04e7b94100d0cdccfe1c2a07/src/libawkward/Index.cpp#L23
making a ListOffsetArray32 form doesn't work:

>>> awkward1.forms.ListOffsetForm("i32", awkward1.forms.EmptyForm())
{
    "class": "UnrecognizedListOffsetArray",
    "offsets": "i8",
    "content": {
        "class": "EmptyArray"
    }
}

I can make the patch.

@nsmith- nsmith- added the bug (unverified) The problem described would be a bug, but needs to be triaged label May 3, 2020
nsmith- added a commit to nsmith-/awkward-1.0 that referenced this issue May 3, 2020
jpivarski pushed a commit that referenced this issue May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (unverified) The problem described would be a bug, but needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant