Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Awkward CUDA Kernel's version should be tied with Awkward #1306

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Awkward CUDA Kernel's version should be tied with Awkward #1306

merged 1 commit into from
Feb 22, 2022

Conversation

sw5sh
Copy link
Collaborator

@sw5sh sw5sh commented Feb 22, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1306 (ac5e17e) into main (5613d44) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/awkward/_v2/contents/listoffsetarray.py 80.41% <ø> (ø)
src/awkward/_v2/operations/structure/ak_argsort.py 100.00% <100.00%> (+25.00%) ⬆️
src/awkward/_v2/contents/content.py 81.63% <0.00%> (+0.15%) ⬆️
src/awkward/_v2/contents/indexedoptionarray.py 86.77% <0.00%> (+0.16%) ⬆️
src/awkward/_v2/contents/listarray.py 88.23% <0.00%> (+0.21%) ⬆️

jpivarski
jpivarski approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested: running

./cuda-build.sh -c 11.4.2 -i

installs awkward-cuda-kernels with version 1.8.0rc5 (latest VERSION_INFO at the time of the test). This package's version number is not 11.4.2, the CUDA version.

@jpivarski jpivarski enabled auto-merge (squash) February 22, 2022 14:53
@jpivarski jpivarski merged commit a19af92 into main Feb 22, 2022
@jpivarski jpivarski deleted the swishdiff/awkward_cuda_version branch February 22, 2022 15:12
@agoose77 agoose77 mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sw5sh @jpivarski