Feat: raise AttributeError
for public Array attributes
#1573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1511
As discussed in the issue, the new behaviour is:
We might have some hidden issues if users employ underscore-prefixed fields. Right now, setting these attributes will write to the
ak.Array
object. However, this shadowing is already accepted when we read from an attribute - class attributes take precedence over fields, just as they do in this PR for writing. Are we happy with this?