Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set VERSION_INFO contents to 2.0.0rc1 #1723

Merged
merged 2 commits into from
Sep 24, 2022

Conversation

agoose77
Copy link
Collaborator

@jpivarski I'm going to merge this without waiting for review, as it's a tiny change, and you've listed it in a todo list. Let me know if that's too presumptive!

@agoose77 agoose77 enabled auto-merge (rebase) September 24, 2022 14:16
@agoose77 agoose77 enabled auto-merge (squash) September 24, 2022 14:16
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I often do VERSION_INFO changes by directly committing to main or main-v* since it really can't break anything that the tests test for.

It's usually a step in making a release, in which I sanity-check the VERSION_INFO four or five times before pressing the button. That only works if the "update VERSION_INFO, tag release" action is single-threaded (i.e. one person doing it, not multiple). So that would need to be re-thought if we're both merging and releasing.

By the way, there was some problem I encountered in the past when setting the version number as part of a PR that did some other thing (such as the feature that motivated the release). I don't remember the reason at present, but it is a very good idea to keep the version number updates as separate commits on main than any other changes.

@agoose77 agoose77 merged commit 0fa2cdb into main Sep 24, 2022
@agoose77 agoose77 deleted the agoose77/chore-set-version-info branch September 24, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants