Add more kernel test cases #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trickarcher Maybe this PR also solves the issue about the missing tests for the kernels you mentioned earlier on slack. |
|
Yes, this fixes that issue. Thanks! |
jpivarski
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Great! Since this passes CI, I'll merge it and then run it on my computer to see how many tests we now have. But I think it's safe to crystallize the Python definitions in specification.yml now.
Now that Uproot 4 documentation is out (https://uproot4.readthedocs.io), I plan to focus on reviewing the set of roles and samples more carefully. I can start on that without the new framework, but I'll want to wait for the "specification as source" framework before integrating it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black seems to be inconsistent with how ti wants to format
from parser_utils import PYGEN_BLACKLIST, SUCCESS_TEST_BLACKLIST, TEST_BLACKLIST