Added dtype argument to ones/zeros/full_like functions #814

HenryDayHall · 2021-04-09T15:37:35Z

Is this the right branch to be making a pull request to?
I still need to add the tests.

for more information, see https://pre-commit.ci

…yHall/awkward-1.0 into henrydayhall/full-like-dtype-arg

for more information, see https://pre-commit.ci

HenryDayHall · 2021-04-13T13:03:02Z

Added the tests, not sure if my testing is idiomatic?

jpivarski

I have no complaints about the testing style. Just one question (below) about chaining through both strings_astype and values_astype.

src/awkward/operations/structure.py

HenryDayHall and others added 9 commits April 9, 2021 16:33

Added dtype argument to ones/zeros/full_like functions

82eb2f2

[pre-commit.ci] auto fixes from pre-commit.com hooks

63c8a0c

for more information, see https://pre-commit.ci

Still have issues in converting strings to bools

d912299

Still have issues in converting strings to bools

6affc4d

[pre-commit.ci] auto fixes from pre-commit.com hooks

e122bf5

for more information, see https://pre-commit.ci

tests work now

18ac079

tests work now

98d65e2

Merge branch 'henrydayhall/full-like-dtype-arg' of github.com:HenryDa…

c44529f

…yHall/awkward-1.0 into henrydayhall/full-like-dtype-arg

[pre-commit.ci] auto fixes from pre-commit.com hooks

f2a3bf9

for more information, see https://pre-commit.ci

HenryDayHall marked this pull request as ready for review April 13, 2021 13:02

HenryDayHall mentioned this pull request Apr 13, 2021

Can np.zeros_like(awkd_array) have a dtype argument? #813

Closed

jpivarski approved these changes Apr 13, 2021

View reviewed changes

src/awkward/operations/structure.py Show resolved Hide resolved

jpivarski linked an issue Apr 13, 2021 that may be closed by this pull request

Can np.zeros_like(awkd_array) have a dtype argument? #813

Closed

jpivarski merged commit 5c413dc into scikit-hep:main Apr 13, 2021

Provide feedback