Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add C++ headers-only distribution configuration #1523

Merged
merged 5 commits into from
Jul 1, 2022

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Jun 30, 2022

as discussed with @jpivarski this restores a config.py, but it defines only header part as follows (no libraries):

% python -m awkward._v2.config
% python -m awkward._v2.config --cflags
-std=c++17 -I/Users/yana/Projects/PR1522/awkward/awkward/src/_v2/cpp-headers
% python -m awkward._v2.config --cflags-only-I
-I/Users/yana/Projects/PR1522/awkward/awkward/src/_v2/cpp-headers
% python -m awkward._v2.config --incdir       
/Users/yana/Projects/PR1522/awkward/awkward/src/_v2/cpp-headers

@ianna ianna requested a review from jpivarski June 30, 2022 15:16
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1523 (946b555) into main (0c6ae03) will decrease coverage by 2.74%.
The diff coverage is 76.88%.

Impacted Files Coverage Δ
...awkward/_v2/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)
...c/awkward/_v2/_connect/rdataframe/to_rdataframe.py 0.00% <0.00%> (ø)
src/awkward/_v2/config.py 0.00% <0.00%> (ø)
src/awkward/_v2/types/_awkward_datashape_parser.py 47.66% <ø> (ø)
src/awkward/_v2/_connect/cling.py 25.99% <9.09%> (-0.35%) ⬇️
src/awkward/_v2/types/recordtype.py 87.06% <91.66%> (+0.83%) ⬆️
src/awkward/_v2/types/type.py 96.46% <96.10%> (-1.27%) ⬇️
src/awkward/_v2/_lookup.py 97.51% <100.00%> (+0.01%) ⬆️
src/awkward/_v2/types/__init__.py 100.00% <100.00%> (ø)
src/awkward/_v2/types/regulartype.py 90.47% <0.00%> (+4.76%) ⬆️

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing: I think this file should have path src/awkward/_v2/config.py so that it can't be confused with the old one. When /_v2//, it will occupy the old space, but then it will be a new major version of Awkward and we expect things like that to change.

Other than that, it's great! Go ahead and merge it when it's moved into the _v2 directory.

@ianna
Copy link
Collaborator Author

ianna commented Jun 30, 2022

Only one thing: I think this file should have path src/awkward/_v2/config.py so that it can't be confused with the old one. When /_v2//, it will occupy the old space, but then it will be a new major version of Awkward and we expect things like that to change.

Other than that, it's great! Go ahead and merge it when it's moved into the _v2 directory.

I did move the file. Now the CI does not trigger the tests...

@ianna ianna merged commit 78a6535 into main Jul 1, 2022
@ianna ianna deleted the ianna/config-cpp-headers-only branch July 1, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants