-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add C++ headers-only distribution configuration #1523
Conversation
for more information, see https://pre-commit.ci
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one thing: I think this file should have path src/awkward/_v2/config.py
so that it can't be confused with the old one. When /_v2/
→ /
, it will occupy the old space, but then it will be a new major version of Awkward and we expect things like that to change.
Other than that, it's great! Go ahead and merge it when it's moved into the _v2
directory.
I did move the file. Now the CI does not trigger the tests... |
as discussed with @jpivarski this restores a config.py, but it defines only header part as follows (no libraries):