Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Initialize values behind the mask in ak.to_numpy #1531

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Fix: Initialize values behind the mask in ak.to_numpy #1531

merged 4 commits into from
Jul 7, 2022

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Jul 6, 2022

This PR aims to fix #1525

@codecov
Copy link

codecov bot commented Jul 6, 2022 •
edited

Codecov Report

Merging #1531 (4a210a6) into main (78a6535) will decrease coverage by 0.12%.
The diff coverage is 57.66%.

Impacted Files Coverage Δ
src/awkward/_v2/contents/indexedoptionarray.py 89.14% <54.54%> (-0.70%) ⬇️
src/awkward/_v2/highlevel.py 70.77% <57.60%> (-2.76%) ⬇️
src/awkward/_v2/_connect/numba/arrayview.py 96.76% <100.00%> (ø)

jpivarski
jpivarski approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/awkward/_v2/contents/indexedoptionarray.py Outdated Show resolved Hide resolved
@jpivarski jpivarski enabled auto-merge (squash) July 7, 2022 13:24
@jpivarski jpivarski merged commit 1db41a0 into main Jul 7, 2022
@jpivarski jpivarski deleted the ioanaif/fix_1525 branch July 7, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When ak.to_numpy makes a np.ma.MaskedArray, the values behind the mask must be initialized
2 participants
@ioanaif @jpivarski