Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving the endian bug on MacOS #1538

Merged
merged 5 commits into from
Jul 9, 2022
Merged

Solving the endian bug on MacOS #1538

merged 5 commits into from
Jul 9, 2022

Conversation

aryan26roy
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1538 (45d0411) into main (78a6535) will decrease coverage by 0.12%.
The diff coverage is 58.27%.

Impacted Files Coverage Δ
src/awkward/_v2/contents/indexedoptionarray.py 89.14% <54.54%> (-0.70%) ⬇️
src/awkward/_v2/highlevel.py 70.77% <57.60%> (-2.76%) ⬇️
src/awkward/_v2/_connect/numba/arrayview.py 96.76% <100.00%> (ø)
src/awkward/_v2/types/recordtype.py 86.72% <100.00%> (-0.35%) ⬇️
src/awkward/_v2/types/numpytype.py 88.09% <0.00%> (-1.20%) ⬇️
src/awkward/_v2/record.py 76.86% <0.00%> (-0.18%) ⬇️
src/awkward/_v2/contents/content.py 76.61% <0.00%> (ø)
src/awkward/_v2/operations/ak_is_none.py 96.55% <0.00%> (+0.39%) ⬆️
src/awkward/_v2/operations/ak_type.py 53.84% <0.00%> (+2.56%) ⬆️

@jpivarski
Copy link
Member

The bug is actually not related to endianness, but some compiler optimization that optimizes away our byteswap function. Mac has the same endianness as all other x86's, but the function that actively swaps was somehow not being invoked.

@jpivarski jpivarski marked this pull request as ready for review July 9, 2022 03:01
@jpivarski jpivarski merged commit 74134f1 into main Jul 9, 2022
@jpivarski jpivarski deleted the aryan-mac-endian-bug branch July 9, 2022 03:02
@jpivarski
Copy link
Member

@all-contributors please add @aryan26roy for code

@allcontributors
Copy link
Contributor

@jpivarski

I've put up a pull request to add @aryan26roy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants