Fix: Missing `axis_wrap_if_negative` Record method in both v1 and v2 #1565

ioanaif · 2022-07-25T19:43:07Z

for more information, see https://pre-commit.ci

codecov · 2022-07-25T20:28:56Z

Codecov Report

Merging #1565 (31985f9) into main (78a6535) will increase coverage by 0.24%.
The diff coverage is 74.25%.

Impacted Files	Coverage Δ
src/awkward/_v2/contents/indexedoptionarray.py	`89.14% <54.54%> (-0.70%)`	⬇️
src/awkward/_v2/highlevel.py	`70.77% <57.60%> (-2.76%)`	⬇️
src/awkward/_v2/operations/ak_from_parquet.py	`87.02% <88.09%> (+37.87%)`	⬆️
src/awkward/_v2/operations/ak_to_parquet.py	`51.02% <95.23%> (+3.02%)`	⬆️
src/awkward/_v2/_connect/numba/arrayview.py	`96.76% <100.00%> (ø)`
src/awkward/_v2/contents/content.py	`76.61% <100.00%> (ø)`
src/awkward/_v2/operations/ak_copy.py	`100.00% <100.00%> (ø)`
src/awkward/_v2/operations/ak_is_none.py	`96.55% <100.00%> (+0.39%)`	⬆️
...awkward/_v2/operations/ak_metadata_from_parquet.py	`100.00% <100.00%> (+68.42%)`	⬆️
src/awkward/_v2/record.py	`77.53% <100.00%> (+0.49%)`	⬆️
... and 20 more

jpivarski

Looks great! #1559 does the other half of this: refusing to allow records in the error cases that came up.

…1565) * Added `axis_wrap_if_negative` method to Record in both v1 and v2 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Renamed test with PR nr Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

ioanaif and others added 3 commits July 25, 2022 21:40

Added axis_wrap_if_negative method to Record in both v1 and v2

ad37a6b

[pre-commit.ci] auto fixes from pre-commit.com hooks

2853fba

for more information, see https://pre-commit.ci

Renamed test with PR nr

31985f9

ioanaif requested a review from jpivarski July 26, 2022 06:27

jpivarski approved these changes Jul 28, 2022

View reviewed changes

jpivarski merged commit 3ee1059 into main Jul 28, 2022

jpivarski deleted the ioanaif/fix-axis-wrap-record-1551 branch July 28, 2022 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Missing `axis_wrap_if_negative` Record method in both v1 and v2 #1565

Fix: Missing `axis_wrap_if_negative` Record method in both v1 and v2 #1565

ioanaif commented Jul 25, 2022

codecov bot commented Jul 25, 2022

jpivarski left a comment

Fix: Missing axis_wrap_if_negative Record method in both v1 and v2 #1565

Fix: Missing axis_wrap_if_negative Record method in both v1 and v2 #1565

Conversation

ioanaif commented Jul 25, 2022

codecov bot commented Jul 25, 2022

Codecov Report

jpivarski left a comment

Choose a reason for hiding this comment

Fix: Missing `axis_wrap_if_negative` Record method in both v1 and v2 #1565

Fix: Missing `axis_wrap_if_negative` Record method in both v1 and v2 #1565