Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow empty RecordArrays in ak.to_layout #1581

Merged
merged 3 commits into from Aug 11, 2022
Merged

Fix: allow empty RecordArrays in ak.to_layout #1581

merged 3 commits into from Aug 11, 2022

Conversation

agoose77
Copy link
Collaborator

Fixes #1578

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1581 (fb64999) into main (9e17f29) will decrease coverage by 0.01%.
The diff coverage is 35.13%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/cuda/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/_connect/numexpr.py 88.40% <0.00%> (ø)
src/awkward/_v2/_connect/pyarrow.py 88.46% <0.00%> (ø)
src/awkward/_v2/contents/bytemaskedarray.py 88.82% <0.00%> (ø)
src/awkward/_v2/contents/indexedarray.py 73.83% <0.00%> (ø)
src/awkward/_v2/contents/indexedoptionarray.py 89.14% <0.00%> (ø)
src/awkward/_v2/contents/listoffsetarray.py 81.85% <0.00%> (ø)
src/awkward/_v2/contents/unionarray.py 86.27% <0.00%> (ø)
src/awkward/_v2/numba.py 93.47% <0.00%> (ø)
src/awkward/_v2/operations/ak_from_avro_file.py 66.66% <0.00%> (ø)
... and 6 more

@agoose77 agoose77 changed the title Fix: allow empty recordarrays in ak.to_layout Fix: allow empty RecordArrays in ak.to_layout Aug 10, 2022
Copy link

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpivarski
Copy link
Member

That fix looks correct to me, also, but the tests are failing because some CI nodes don't have pyarrow installed. You just need to put a

pyarrow = pytest.importorskip("pyarrow")

at the top of the test file.

And then squash-and-merge when it works; this seems to have been an easy fix!

@agoose77 agoose77 merged commit 508af5a into main Aug 11, 2022
@agoose77 agoose77 deleted the fix-to-arrow branch August 11, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of Empty Objects is not supported
3 participants