Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: include Python 3.11 #1602

Merged
merged 8 commits into from Aug 24, 2022
Merged

chore: include Python 3.11 #1602

merged 8 commits into from Aug 24, 2022

Conversation

henryiii
Copy link
Member

Testing this out now that NumPy supports Python 3.11 with binary wheels.

@henryiii
Copy link
Member Author

This will be easier after #1550, so will rebase after that.

@codecov
Copy link

codecov bot commented Aug 18, 2022 •
edited

Codecov Report

Merging #1602 (10b09e0) into main (9e17f29) will decrease coverage by 0.11%.
The diff coverage is 51.53%.

❗ Current head 10b09e0 differs from pull request most recent head 3703600. Consider uploading reports for the commit 3703600 to get more accurate results

Impacted Files Coverage Δ
src/awkward/_v2/_connect/cuda/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/_connect/numexpr.py 88.40% <0.00%> (ø)
src/awkward/_v2/_connect/pyarrow.py 88.46% <0.00%> (ø)
src/awkward/_v2/_lookup.py 98.68% <ø> (+1.17%) ⬆️
src/awkward/_v2/numba.py 93.47% <0.00%> (ø)
src/awkward/_v2/operations/ak_from_avro_file.py 66.66% <0.00%> (ø)
src/awkward/_v2/operations/ak_local_index.py 100.00% <ø> (ø)
src/awkward/_v2/operations/ak_type.py 53.84% <0.00%> (ø)
src/awkward/_v2/_connect/cling.py 24.90% <2.73%> (-1.10%) ⬇️
src/awkward/_v2/operations/ak_transform.py 8.62% <8.62%> (ø)
... and 30 more

@henryiii
Copy link
Member Author

This should probably be done instead of #1583 since that one doesn't add testing for 3.11, but just the new wheel builds only.

@jpivarski jpivarski mentioned this pull request Aug 18, 2022
Closed
@henryiii henryiii force-pushed the henryiii/chore/python311 branch 2 times, most recently from d83a4af to 459bf2d Compare August 22, 2022 18:41
@henryiii
chore: include Python 3.11
4b0d6b9 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
ci: avoid numba on 3.11
f8209cb
@henryiii
ci: ignore more missing 3.11 packages
b1171d8 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
ci: ignore more missing 3.11 pyarrow
82afb7d 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
tests: ignore dep warning from lark
c7a5e66 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
ci: filter a few more things
a791612 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii and others added 2 commits August 22, 2022 15:11
@henryiii
Update tests.yml
8bc70f7
@henryiii
ci: don't build 3.11 on manylinux1
3703600 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as ready for review August 23, 2022 01:57
henryiii
henryiii commented Aug 23, 2022
View reviewed changes
.github/workflows/tests.yml
- uses: pypa/cibuildwheel@v2.9.0
if: matrix.os == 'ubuntu-latest'
env:
CIBW_BUILD: cp311-manylinux_x86_64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are hardcoding manylinux1 above, and manylinux1 doesn't support 3.11 (or 3.10, IIRC), so made this a separate step.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what becomes easier when we drop Python 3.6? I'm going to open issues for dropping 3.6 in Uproot and Awkward as a reminder.

.pre-commit-config.yaml
@@ -19,6 +19,7 @@ repos:
rev: v2.0.0
hooks:
- id: setup-cfg-fmt
args: [--include-version-classifiers, --max-py-version=3.11]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got missed recently, you now need --include-version-classifiers as of setup-cfg-fmt 2.

pyproject.toml
@@ -74,6 +74,7 @@ filterwarnings = [
"ignore:the imp module is deprecated in favour of importlib:DeprecationWarning", # move to importlib to fix (setuptools issue)
"ignore:The NumPy module was reloaded:UserWarning",
"ignore:.*np\\.MachAr.*:DeprecationWarning", # until https://github.com/numba/numba/issues/7758 is fixed
"ignore:module 'sre_.*' is deprecated:DeprecationWarning", # From lark & Python 3.11
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this can also be "default", "once", or "all" if you want the warning to still show up in the tests. But they aren't really our fault so I think ignoring them is fine. But there are options.

jpivarski
jpivarski approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Similar to the last few new tests, I'll flip the switch to start requiring "3.11-dev" in about a week. On my calendar for August 31.

@jpivarski jpivarski merged commit 0836699 into main Aug 24, 2022
@jpivarski jpivarski deleted the henryiii/chore/python311 branch August 24, 2022 19:09
@jpivarski
Copy link
Member

To be clear: this updates pybind11 on purpose, right? (I missed that when scanning over the files that have changed, since the whole submodule is one small line.) The new pybind11 commit coincides with release 2.10.0, which looks very intentional.

I'll make a note in tomorrow's slides to be careful about accidentally back-porting pybind11 (and I'll be on the lookout for that, too, since it happens so easily).

@henryiii
Copy link
Member Author

pybind11 2.10.0 is required for CPython 3.11 support, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henryiii @jpivarski