Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CITATION.cff #1717

Merged
merged 3 commits into from
Sep 23, 2022
Merged

chore: update CITATION.cff #1717

merged 3 commits into from
Sep 23, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Sep 22, 2022

Fixes #1713

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1717 (6076c14) into main (e692946) will increase coverage by 0.38%.
The diff coverage is 84.98%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_v2/_connect/jax/__init__.py 90.47% <ø> (+1.58%) ⬆️
src/awkward/_v2/config.py 0.00% <0.00%> (ø)
src/awkward/_v2/operations/ak_broadcast_arrays.py 100.00% <ø> (+4.34%) ⬆️
src/awkward/_v2/operations/ak_transform.py 65.51% <ø> (+56.89%) ⬆️
src/awkward/_v2/types/uniontype.py 84.61% <ø> (ø)
src/awkward/_v2/behaviors/categorical.py 73.13% <60.00%> (-8.94%) ⬇️
src/awkward/_v2/contents/bitmaskedarray.py 71.42% <60.00%> (-0.11%) ⬇️
src/awkward/_v2/contents/bytemaskedarray.py 88.32% <60.00%> (-0.03%) ⬇️
src/awkward/_v2/contents/listarray.py 91.89% <60.00%> (-0.02%) ⬇️
src/awkward/_v2/contents/unmaskedarray.py 70.76% <60.00%> (-0.13%) ⬇️
... and 56 more

@jpivarski
Copy link
Member

To answer your question from issue #1713, yes, Manasvi definitely qualifies as an author and I think she should be added to the list.

Is this good with you, @ManasviGoyal? Would you prefer a different email and do you have an ORCID? If you don't have an ORCID, it's easy to set one up: https://orcid.org/ This is a unique identifier that links all of your academic publications.

@ManasviGoyal
Copy link
Collaborator

To answer your question from issue #1713, yes, Manasvi definitely qualifies as an author and I think she should be added to the list.

Is this good with you, @ManasviGoyal? Would you prefer a different email and do you have an ORCID? If you don't have an ORCID, it's easy to set one up: https://orcid.org/ This is a unique identifier that links all of your academic publications.

Yes, @jpivarski this email works. I have set up an ORCID. here is the link - https://orcid.org/0000-0001-6321-7491. @agoose77 please add this too. Thanks.

@agoose77 agoose77 marked this pull request as ready for review September 22, 2022 22:41
@jpivarski
Copy link
Member

Great! Then I'll merge the new author list.

@jpivarski jpivarski merged commit 3c5d946 into main Sep 23, 2022
@jpivarski jpivarski deleted the agoose77/chore-update-citation branch September 23, 2022 00:56
@ManasviGoyal
Copy link
Collaborator

ManasviGoyal commented Sep 24, 2022

@agoose77 I was checking the doi link and noticed that the authors and the commits on zenodo are not up to date with the changes made to the CITATION.cff. Just wanted to bring it to your notice if it's something unusual. Thanks.

@agoose77
Copy link
Collaborator Author

I believe the Zenodo information will update when we next make a release, right @jpivarski?

@jpivarski
Copy link
Member

Yes, that's correct. I discovered it experimentally yesterday with Uproot: adding a CITATION.cff when there hasn't been one before had no effect on Zenodo until I made a release. Uproot releases take a few minutes to make, but Awkward takes 4 hours, though maybe that will be a bit less (1 hour?) with v1 dropped. We'll be making such a release soon, and I can make sure to tell you when that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Manasvi (and any others?) to CITATION.cff / Zenodo
3 participants